Repository navigation
feat(build): support Julia (.jl) nodes in posix and windows builds - #669
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
mkconcore.py rejected .jl nodes for every build type except docker
("Extension .jl is unsupported"), so Julia studies could not run locally.
- copy concore.jl into node folders and write run/debug scripts for
posix, macOS (osascript), Ubuntu (xterm) and Windows
- add JULIAEXE/JULIAWIN settings (env vars and concore.tools)
- let concore status/stop recognise Julia nodes
- stop concore validate warning about the .jl extension
- add tests for the generated scripts
|
🎉 Welcome aboard, @yadavchiragg! Thank you for your first pull request in concore. Please ensure that you are contributing to the dev branch. Your contribution means a lot to us. We'll review it shortly. Please ensure you have reviewed our: If you have any questions, feel free to ask. Happy coding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Julia nodes only work with
--type docker. For posix, macOS, Ubuntu and Windows builds,mkconcore.py stops with "Extension .jl is unsupported", e.g.
python mkconcore.py demo/sampleJ.graphml demo out posix.Change
generate build/run/debug scripts for posix, macOS, Ubuntu and Windows; add
JULIAEXE/JULIAWIN (env vars CONCORE_JULIAEXE/WIN and concore.tools). The docker path
still uses concoredocker.jl.
status/stoprecognise Julia nodes (concore.jl, concoredocker.jl);validateno longer warns about the .jl extension.Testing
every build type and checks the generated scripts. No Julia needed.
concore build demo/sampleJ.graphml --type posixfailed with"Extension .jl is unsupported"; after it, the study builds and the Julia
node starts and runs (
bash build && bash run).Not included, to keep this small: a
concore doctorcheck for Julia and Julia in theconcore initwizard. Happy to follow up.